From e6f95ef02814468b5567a25bfde0fbb7e99c76b8 Mon Sep 17 00:00:00 2001 From: Stepan Usatiuk Date: Sat, 19 Apr 2025 11:12:04 +0200 Subject: [PATCH] Remove supportlib nice idea, but ram usage explosion seems to cancel out the benefits --- .github/workflows/server.yml | 114 +----------------- Dockerfile.ci | 2 - dhfs-parent/.run/Main 2.run.xml | 2 +- dhfs-parent/.run/Main.run.xml | 2 +- dhfs-parent/dhfs-app/pom.xml | 5 - .../usatiuk/dhfs/integration/DhfsImage.java | 1 - .../src/test/resources/application.properties | 1 - dhfs-parent/dhfs-fs/pom.xml | 5 - .../src/test/resources/application.properties | 1 - dhfs-parent/dhfs-fuse/pom.xml | 5 - .../java/com/usatiuk/dhfs/fuse/DhfsFuse.java | 4 +- .../src/test/resources/application.properties | 1 - dhfs-parent/objects/pom.xml | 5 - .../com/usatiuk/objects/JObjectKeyImpl.java | 4 +- dhfs-parent/pom.xml | 5 - dhfs-parent/supportlib/pom.xml | 114 ------------------ .../dhfs/supportlib/DhfsNativeLibFinder.java | 15 --- .../usatiuk/dhfs/supportlib/DhfsSupport.java | 35 ------ .../dhfs/supportlib/DhfsSupportImpl.java | 11 -- .../supportlib/DhfsSupportImplFallback.java | 21 ---- .../supportlib/DhfsSupportImplNative.java | 20 --- .../dhfs/supportlib/DhfsSupportNative.java | 20 --- .../com/usatiuk/dhfs/supportlib/SysUtils.java | 43 ------- .../supportlib/UninitializedByteBuffer.java | 28 ----- dhfs-parent/sync-base/pom.xml | 5 - .../src/test/resources/application.properties | 1 - dockerentry.sh | 1 - libdhfs_support/.gitignore | 83 ------------- libdhfs_support/CMakeLists.txt | 39 ------ .../DhfsSupportNative/CMakeLists.txt | 26 ---- .../DhfsSupportNative/LibPathDummy.java | 9 -- .../src/DhfsSupportNative.cpp | 55 --------- libdhfs_support/builder/Dockerfile | 3 - libdhfs_support/builder/cross-build.sh | 56 --------- libdhfs_support/builder/docker-launch.sh | 21 ---- libdhfs_support/helpers/CMakeLists.txt | 9 -- .../helpers/include/MemoryHelpers.h | 12 -- libdhfs_support/helpers/include/Utils.h | 41 ------- libdhfs_support/helpers/src/MemoryHelpers.cpp | 14 --- run-wrapper/run | 1 - 40 files changed, 7 insertions(+), 833 deletions(-) delete mode 100644 dhfs-parent/supportlib/pom.xml delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsNativeLibFinder.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsSupport.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsSupportImpl.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsSupportImplFallback.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsSupportImplNative.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/DhfsSupportNative.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/SysUtils.java delete mode 100644 dhfs-parent/supportlib/src/main/java/com/usatiuk/dhfs/supportlib/UninitializedByteBuffer.java delete mode 100644 libdhfs_support/.gitignore delete mode 100644 libdhfs_support/CMakeLists.txt delete mode 100644 libdhfs_support/DhfsSupportNative/CMakeLists.txt delete mode 100644 libdhfs_support/DhfsSupportNative/LibPathDummy.java delete mode 100644 libdhfs_support/DhfsSupportNative/src/DhfsSupportNative.cpp delete mode 100644 libdhfs_support/builder/Dockerfile delete mode 100755 libdhfs_support/builder/cross-build.sh delete mode 100755 libdhfs_support/builder/docker-launch.sh delete mode 100644 libdhfs_support/helpers/CMakeLists.txt delete mode 100644 libdhfs_support/helpers/include/MemoryHelpers.h delete mode 100644 libdhfs_support/helpers/include/Utils.h delete mode 100644 libdhfs_support/helpers/src/MemoryHelpers.cpp diff --git a/.github/workflows/server.yml b/.github/workflows/server.yml index 780e4701..2b140c66 100644 --- a/.github/workflows/server.yml +++ b/.github/workflows/server.yml @@ -89,102 +89,6 @@ jobs: name: Webui path: webui/dist - build-native-libs: - strategy: - matrix: - include: - - os: ubuntu-latest - cross: "linux/amd64" - - os: ubuntu-latest - cross: "linux/arm64" - - os: macos-latest - - runs-on: ${{ matrix.os }} - env: - DO_LOCAL_BUILD: ${{ matrix.os == 'macos-latest' }} - DOCKER_PLATFORM: ${{ matrix.cross || 'NATIVE' }} - - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Set SANITIZED_DOCKER_PLATFORM - run: echo "SANITIZED_DOCKER_PLATFORM=$(echo $DOCKER_PLATFORM | tr / _ )" >> $GITHUB_ENV - - - name: Set DOCKER_BUILDER_IMAGE - run: echo "DOCKER_BUILDER_IMAGE=dhfs_lib_builder-${{matrix.os}}-$SANITIZED_DOCKER_PLATFORM" >> $GITHUB_ENV - - - name: Build config - run: | - echo DO_LOCAL_BUILD: $DO_LOCAL_BUILD - echo DOCKER_PLATFORM: $DOCKER_PLATFORM - echo SANITIZED_DOCKER_PLATFORM: $SANITIZED_DOCKER_PLATFORM - echo DOCKER_BUILDER_IMAGE: $DOCKER_BUILDER_IMAGE - - - name: Set up JDK 21 - if: ${{ env.DO_LOCAL_BUILD == 'TRUE' }} - uses: actions/setup-java@v4 - with: - java-version: "21" - distribution: "zulu" - cache: maven - - - name: Set up Docker Buildx - if: ${{ env.DO_LOCAL_BUILD != 'TRUE' }} - uses: docker/setup-buildx-action@v3 - - - name: Set up QEMU - if: ${{ env.DO_LOCAL_BUILD != 'TRUE' }} - uses: docker/setup-qemu-action@v3 - - - name: Build Docker builder image - if: ${{ env.DO_LOCAL_BUILD != 'TRUE' }} - uses: docker/build-push-action@v5 - with: - context: ./libdhfs_support/builder - file: ./libdhfs_support/builder/Dockerfile - push: false - platforms: ${{ env.DOCKER_PLATFORM }} - tags: ${{ env.DOCKER_BUILDER_IMAGE }} - cache-from: type=gha,scope=build-${{ env.DOCKER_BUILDER_IMAGE }} - cache-to: type=gha,mode=max,scope=build-${{ env.DOCKER_BUILDER_IMAGE }} - load: true - - - name: Build the library - run: | - CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Release" libdhfs_support/builder/cross-build.sh both build "$(pwd)/result" - - - name: Upload build - uses: actions/upload-artifact@v4 - with: - name: NativeLib-${{ matrix.os }}-${{ env.SANITIZED_DOCKER_PLATFORM }} - path: result - - merge-native-libs: - runs-on: ubuntu-latest - needs: [build-native-libs] - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Download artifacts - uses: actions/download-artifact@v4 - with: - path: downloaded-libs - - - name: Merge all - run: rsync -av downloaded-libs/NativeLib*/* result/ - - - name: Check that libs exists - run: | - test -f "result/Linux-x86_64/libdhfs_support.so" || exit 1 - - - name: Upload - uses: actions/upload-artifact@v4 - with: - name: NativeLibs - path: result - publish-docker: runs-on: ubuntu-latest permissions: @@ -194,7 +98,7 @@ jobs: # with sigstore/fulcio when running outside of PRs. id-token: write - needs: [build-webui, merge-native-libs, build-dhfs] + needs: [build-webui, build-dhfs] steps: - name: Checkout repository @@ -212,12 +116,6 @@ jobs: name: Webui path: webui-dist-downloaded - - name: Download native libs - uses: actions/download-artifact@v4 - with: - name: NativeLibs - path: dhfs-native-downloaded - - name: Show all the files run: find . @@ -293,7 +191,7 @@ jobs: # with sigstore/fulcio when running outside of PRs. id-token: write - needs: [build-webui, merge-native-libs, build-dhfs] + needs: [build-webui, build-dhfs] steps: - name: Checkout repository @@ -309,11 +207,6 @@ jobs: name: Webui path: webui-dist-downloaded - - uses: actions/download-artifact@v4 - with: - name: NativeLibs - path: dhfs-native-downloaded - - name: Show all the files run: find . @@ -326,9 +219,6 @@ jobs: - name: Copy Webui run: cp -r ./webui-dist-downloaded "run-wrapper-out/dhfs/app/Webui" - - name: Copy Webui - run: cp -r ./dhfs-native-downloaded "run-wrapper-out/dhfs/app/NativeLibs" - - name: Copy run wrapper run: cp -r ./run-wrapper/* "run-wrapper-out/dhfs/app/" diff --git a/Dockerfile.ci b/Dockerfile.ci index de2b972c..98764f20 100644 --- a/Dockerfile.ci +++ b/Dockerfile.ci @@ -9,8 +9,6 @@ COPY ./dhfs-package-downloaded/*.jar . COPY ./dhfs-package-downloaded/app . COPY ./dhfs-package-downloaded/quarkus . -WORKDIR /usr/src/app/native-libs -COPY ./dhfs-native-downloaded/. . WORKDIR /usr/src/app/webui COPY ./webui-dist-downloaded/. . diff --git a/dhfs-parent/.run/Main 2.run.xml b/dhfs-parent/.run/Main 2.run.xml index 795d2286..a639a231 100644 --- a/dhfs-parent/.run/Main 2.run.xml +++ b/dhfs-parent/.run/Main 2.run.xml @@ -2,7 +2,7 @@