stepus53/photos
1
0
Fork 0
mirror of https://github.com/usatiuk/photos.git synced 2025-10-28 23:37:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix failed login hanging bug

Browse Source
This commit is contained in:
Stepan Usatiuk
2023-07-30 20:51:13 +02:00
parent fe58b33657
commit 45decc60a7
6 changed files with 92 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/app.ts
View File

@@ -15,7 +15,7 @@ import { config, EnvType } from "~config";
import { userRouter } from "~routes/users";
import { devRouter } from "~routes/dev";
import { photosRouter } from "~routes/photos";
import { TUserJWT } from "~shared/types";
import { TAPIErrorResponse, TUserJWT } from "~shared/types";
export interface IAppState extends Koa.DefaultState {
user?: TUserJWT;
@@ -101,6 +101,6 @@ app.on("error", (err, ctx) => {
console.log(err);
ctx.body = {
error: err.message,
data: false,
};
data: null,
} as TAPIErrorResponse;
});

10
backend/src/tests/integration/users.test.ts
View File

@@ -83,7 +83,7 @@ describe("users", function () {
const body = response.body as TUserLoginRespBody;
expect(body.error).to.be.equal("User not found");
expect(body.data).to.be.false;
expect(body.data).to.be.null;
});
it("should signup user", async function () {
@@ -127,7 +127,7 @@ describe("users", function () {
const body = response.body as TUserSignupRespBody;
expect(body.error).to.be.equal("Signups not allowed");
expect(body.data).to.be.false;
expect(body.data).to.be.null;
});
it("should signup first user and it should be admin, do not signup new users (by default)", async function () {
@@ -170,7 +170,7 @@ describe("users", function () {
const body2 = response2.body as TUserSignupRespBody;
expect(body2.error).to.be.equal("Signups not allowed");
expect(body2.data).to.be.false;
expect(body2.data).to.be.null;
});
it("should signup first user and it should be admin, but not new ones", async function () {
@@ -240,7 +240,7 @@ describe("users", function () {
const body = response.body as TUserSignupRespBody;
expect(body.error).to.be.equal("User already exists");
expect(body.data).to.be.false;
expect(body.data).to.be.null;
});
it("should change user's password", async function () {
@@ -291,6 +291,6 @@ describe("users", function () {
const badLoginBody = badLoginResponse.body as TUserLoginRespBody;
expect(badLoginBody.error).to.be.equal("User not found");
expect(badLoginBody.data).to.be.false;
expect(badLoginBody.data).to.be.null;
});
});