fix chat creating/updating 404

server/src/main/java/com/usatiuk/tjv/y/server/controller/ApiExceptionHandler.java

@@ -47,9 +47,13 @@ public class ApiExceptionHandler extends ResponseEntityExceptionHandler {
 
     @ExceptionHandler(DataIntegrityViolationException.class)
     protected ResponseEntity<Object> handleDataIntegrityViolationException(DataIntegrityViolationException ex, WebRequest request) {
-        return handleExceptionInternal(ex,
+        if (ex.getRootCause() instanceof ConstraintViolationException) {
-                new ErrorTo(List.of("Something is wrong with your request"), HttpStatus.BAD_REQUEST.value()),
+            return handleConstraintViolation((ConstraintViolationException) ex.getRootCause(), request);
-                new HttpHeaders(), HttpStatus.BAD_REQUEST, request);
+        } else {
+            return handleExceptionInternal(ex,
+                    new ErrorTo(List.of("Something is wrong with your request"), HttpStatus.BAD_REQUEST.value()),
+                    new HttpHeaders(), HttpStatus.BAD_REQUEST, request);
+        }
     }
 
     @ExceptionHandler(AuthenticationException.class)

server/src/main/java/com/usatiuk/tjv/y/server/service/ChatServiceImpl.java

@@ -48,7 +48,11 @@ public class ChatServiceImpl implements ChatService {
 
         chat.setCreator(entityManager.getReference(Person.class, authentication.getName()));
         chat.setMembers(Arrays.stream(chatCreateTo.memberUuids()).map(
-                p -> entityManager.getReference(Person.class, p)
+                p -> {
+                    if (entityManager.find(Person.class, p) == null)
+                        throw new NotFoundException("User with uuid " + p + " not found");
+                    return entityManager.getReference(Person.class, p);
+                }
         ).toList());
         chat.setName(chatCreateTo.name());
 
@@ -67,7 +71,11 @@ public class ChatServiceImpl implements ChatService {
             throw new BadInputException("Chat must have members other than its creator");
 
         chat.setMembers(new ArrayList<>(Arrays.stream(chatCreateTo.memberUuids()).map(
-                p -> entityManager.getReference(Person.class, p)
+                p -> {
+                    if (entityManager.find(Person.class, p) == null)
+                        throw new NotFoundException("User with uuid " + p + " not found");
+                    return entityManager.getReference(Person.class, p);
+                }
         ).toList()));
         chat.setName(chatCreateTo.name());
 

server/src/test/java/com/usatiuk/tjv/y/server/controller/ChatControllerTest.java

@@ -44,6 +44,19 @@ public class ChatControllerTest extends DemoDataDbTest {
         Assertions.assertTrue(chatRepository.findByName("chatnew").isPresent());
     }
 
+    @Test
+    void chatCreateWithBadUuid404() {
+        var response = restTemplate.exchange(addr + "/chat", HttpMethod.POST,
+                new HttpEntity<>(new ChatCreateTo("chatnew", new String[]{person1.getUuid(), "asdfasdfasdf"}), createAuthHeaders(person1Auth)),
+                ErrorTo.class);
+
+        Assertions.assertNotNull(response);
+        Assertions.assertEquals(HttpStatus.NOT_FOUND, response.getStatusCode());
+
+        var toResponse = response.getBody();
+        Assertions.assertNotNull(toResponse);
+    }
+
     @Test
     void shouldGetChat() {
         for (TokenResponseTo t : new TokenResponseTo[]{person1Auth, person2Auth}) {