stepus53/writer
1
0
Fork 0
mirror of https://github.com/usatiuk/writer.git synced 2025-10-29 00:17:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove state mutations from render

Browse Source
This commit is contained in:
Stepan Usatiuk
2019-02-11 14:55:58 +03:00
parent 37824ad373
commit adde6566db
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/Documents/DocumentEdit.tsx
View File

@@ -107,7 +107,6 @@ export class DocumentEditComponent extends React.PureComponent<
</div>
);
} else {
this.tryLoad();
return this.props.spinner && <LoadingStub />;
}
}
@@ -138,6 +137,10 @@ export class DocumentEditComponent extends React.PureComponent<
this.tryLoad();
}
public componentDidMount() {
this.tryLoad();
}
private tryLoad() {
if (!this.props.allDocs && !this.props.fetching) {
this.props.fetchDocs();

15
frontend/src/Documents/Overview.tsx
View File

@@ -47,12 +47,21 @@ export class OverviewComponent extends React.PureComponent<
</div>
);
} else {
if (!this.props.fetching) {
this.props.fetchDocs();
}
return this.props.spinner && <LoadingStub />;
}
}
public componentDidUpdate() {
if (!this.props.allDocs && !this.props.fetching) {
this.props.fetchDocs();
}
}
public componentDidMount() {
if (!this.props.allDocs && !this.props.fetching) {
this.props.fetchDocs();
}
}
}
function mapStateToProps(state: IAppState) {